zephyr: Convert port to use new event waiting functions. #18685
+31
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new argument is added to this function to select whether it exits early when signalled via `mp_hal_signal_event()`, so it can be used to wait for general events (rather than just a specific semaphore). And rename this function to `mp_hal_wait_event()` to better match its new semantics. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Member
Author
|
Converting to draft until I can fix the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts the zephyr port to use the new event waiting mechanism, with the
MICROPY_INTERNAL_WFEmacro.As part of this, the
mp_hal_wait_sem()function is updated so it can exit early when an event occurs. That allows it to be used byMICROPY_INTERNAL_WFEto implement efficient waiting, so calls likemp_event_wait_indefinite()will actually suspend the thread until an event wakes it.Testing
Tested on frdm_k64f, running the full test suite. There were no regressions. Note that the new event logic in
machine_uart.cis tested bytests/extmod/machine_uart_tx.py(by using a customtarget_wiring.pyfile).Trade-offs and Alternatives
When threading is enabled
mp_hal_wait_sem()does not work correctly due to global state. But that's the topic of a separate PR #17866.