8000 coverage: Add missing MP_OBJ_FROM_PTR casts. by jepler · Pull Request #17619 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

coverage: Add missing MP_OBJ_FROM_PTR casts. #17619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

coverage: Add missing MP_OBJ_FROM_PTR casts. #17619

wants to merge 1 commit into from
+2 −2

Conversation

jepler
Copy link
Contributor
@jepler jepler commented Jul 5, 2025

Summary

An attempt to build the coverage module into the nanbox binary failed, but pointed out that these sites needed explicit conversion from pointer to object.

Testing

I locally did a coverage build on Linux. However, only building this file as part of the nanbox build (which is not done) would reveal whether the added casts corrected the problem.

@jepler
coverage: Add missing MP_OBJ_FROM_PTR casts.
7352a57 
An attempt to build the coverage module into the nanbox binary
failed, but pointed out that these sites needed explicit conversion
from pointer to object.

Signed-off-by: Jeff Epler <jepler@gmail.com>
@jepler jepler mentioned this pull request Jul 5, 2025
Open
@codecov Codecov
Copy link
codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (431b791) to head (7352a57).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17619   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         171      171           
  Lines       22140    22140           
=======================================
  Hits        21749    21749           
  Misses        391      391

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 5, 2025

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees
No one assigned
Labels
port-unix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @dpgeorge
0