zephyr: Use UART for console as default, not CONSOLE_SUBSYS. #17610
+10
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets qemu_x86 and qemu_cortex_m3 building with `prj.conf` settings. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Most boards enable the UART console because it's needed for USB (where USB CDC creates a virtual UART), and for ctrl-C to work. The `prj_minimal.conf` settings still use CONSOLE_SUBSYS. Fixes issue micropython#17608. Signed-off-by: Damien George <damien@micropython.org>
|
Works on XIAO BLE NRF52840 SENSE board. |
That's good, thanks for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions
2D5A
on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most zephyr boards enable the UART console because it's needed for USB (where USB CDC creates a virtual UART), and for ctrl-C to work. This PR makes that option the default (prior to this PR, CONSOLE_SUBSYS was the default).
The
prj_minimal.confsettings still use CONSOLE_SUBSYS, and show how it can be configured.Fixes issue #17608.
(I also updated the qemu board configurations so they work with
prj.conf, which was needed for testing.)Testing
Tested a REPL on: