Skip to content
dpgeorge
force-pushed
the
tests-extmod-asyncio-iterator-event-remove-fstring
branch
from
June 23, 2025 03:17
Navigation Menu
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some targets don't have f-strings enabled. Signed-off-by: Damien George <damien@micropython.org>
8f04901 to
a28aa32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17550 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 169 169
Lines 21950 21950
=======================================
Hits 21636 21636
Misses 314 314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some targets don't have f-strings enabled, so try not to use them in tests. Rather use
str.formatwhich is more portable.Testing
Tested on SEEED_XIAO_SAMD21. Before this change the test would fail with
SyntaxError. Now it skips.