nrf/softdevice : Add function to set the BT address #17406
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Blafy <alban.boye@protonmail.com>
df80ad0 to
c06b6df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On NRF port, this PR implements
sd_ble_gap_addr_setfrom the Soft Device API. You can customize the bluetooth mac address.Testing
I have only tested it on a Xiao BLE board with SD v140.
Trade-offs and Alternatives
This is my first PR, and I am quite rusty with C. I am not sure if this is a clean binding, as I am not familiar with the MP_* objects and methods. Also, I have set the addr_type to
BLE_GAP_ADDR_TYPE_PUBLIC.Maybe it is better to have only a ble.address() method with 2 signatures instead (0 argument = get, otherwise set) ?