8000 tools/verifygitlog.py: Allow long co-author and sign-off names. by DvdGiessen · Pull Request #17302 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

tools/verifygitlog.py: Allow long co-author and sign-off names. #17302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

tools/verifygitlog.py: Allow long co-author and sign-off names. #17302

merged 1 commit into from
May 15, 2025

Conversation

DvdGiessen
Copy link
Contributor
@DvdGiessen DvdGiessen commented May 14, 2025 •
edited
Loading

While rebasing #13390 I noticed that the commit messages were being rejected due to the author name on the required Signed-off-by: line being longer than the maximum line length. I don't think we should be enforcing a maximum length for human names.

This change disables the line length check for lines that start with Co-authored-by: or Signed-off-by: .

I've opened a sibling PR on for updating micropython-lib as well: micropython/micropython-lib#1007

This was referenced May 14, 2025
Merged
Open
@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@codecov Codecov
Copy link
codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (51b821c) to head (4208970).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17302   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         169      169           
  Lines       21897    21897           
=======================================
  Hits        21579    21579           
  Misses        318      318

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DvdGiessen DvdGiessen force-pushed the verifygitlog_long_names branch from bb3190b to 2e02407 Compare May 14, 2025 16:38
projectgus
projectgus approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor
@projectgus projectgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, we should not punish the long-named (and long-emailed-addressed) authors amongst us. 😁

@projectgus projectgus requested a review from dpgeorge May 14, 2025 23:40
@DvdGiessen @dpgeorge
tools/verifygitlog.py: Allow long co-author and sign-off names.
4208970 
Signed-off-by: Daniël van de Giessen <daniel@dvdgiessen.nl>
@dpgeorge dpgeorge force-pushed the verifygitlog_long_names branch from 2e02407 to 4208970 Compare May 15, 2025 03:04
@dpgeorge dpgeorge merged commit 4208970 into micropython:master May 15, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@projectgus projectgus projectgus approved these changes

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DvdGiessen @projectgus @dpgeorge
0