ESP32_GENERIC_C3/mpconfigboard.h: Add defaults for I2C pins. #17113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rick Sorensen <rick.sorensen@gmail.com>
Signed-off-by: Rick Sorensen <rick.sorensen@gmail.com>
Signed-off-by: Rick Sorensen <rick.sorensen@gmail.com>
Signed-off-by: Rick Sorensen <rick.sorensen@gmail.com>
Signed-off-by: Rick Sorensen <rick.sorensen@gmail.com>
|
I suggest to fix it in Eg: #ifndef MICROPY_HW_I2C0_SCL
#if CONFIG_IDF_TARGET_ESP32C3
#define MICROPY_HW_I2C0_SCL (GPIO_NUM_6)
#define MICROPY_HW_I2C0_SDA (GPIO_NUM_7)
#else
#define MICROPY_HW_I2C0_SCL (GPIO_NUM_18)
#define MICROPY_HW_I2C0_SDA (GPIO_NUM_19)
#endif
#endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the ESP32C3 (XIAO C3 for example) the default I2C pins conflicted with the
USB pins resulting in REPL hanging after using the new I2C initializer without
parameters.
Reference:
#17103
#16671
Testing
I tested on an XIAO ESP32C3 board, using the micropython master development branch.
Trade-offs and Alternatives
While the values I defaulted to should allow for safe construction of an I2C object,
they may not be correct for any particular wiring.
I would suggest the documentation be updated for board configurations to include the
necessary default pin parameters.
Another valid approach would be to require the parameters (port id, scl, sda) for every
I2C object creation - my favorite for consistency.