8000 extmod/modtls_mbedtls: Add support for TLS PSK by keenanjohnson · Pull Request #17074 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

extmod/modtls_mbedtls: Add support for TLS PSK #17074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

extmod/modtls_mbedtls: Add support for TLS PSK #17074

wants to merge 21 commits into from
+234 −0

Conversation

keenanjohnson
Copy link
Contributor
@keenanjohnson keenanjohnson commented Apr 4, 2025 •
edited
Loading

This pull request adds support to the ssl module for TLS-PSK (pre-shared key) authentication.

@keenanjohnson
extmod/modtls_mbedtls: Add support for TLS PSK
5684436 
Signed-off-by: Keenan Johnson <keenan.johnson@gmail.com>
@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 4, 2025 •
edited
Loading

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64: +2952 +0.345% standard[incl +192(data) +64(bss)]
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2: +1628 +0.177% RPI_PICO_W[incl +28(bss)]
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@codecov Codecov
Copy link
codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.53%. Comparing base (3805e65) to head (1622787).
Report is 161 commits behind head on master.

Files with missing lines Patch % Lines
extmod/modtls_mbedtls.c 93.87% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #17074      +/-   ##
==========================================
- Coverage   98.54%   98.53%   -0.01%     
==========================================
  Files         169      169              
  Lines       21890    21939      +49     
==========================================
+ Hits        21571    21618      +47     
- Misses        319      321       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keenanjohnson keenanjohnson mentioned this pull request Apr 30, 2025
Open
@dpgeorge dpgeorge added the extmod Relates to extmod/ directory in source label May 7, 2025
@keenanjohnson
Copy link
Contributor Author

Hey @projectgus and @dpgeorge . I've created this draft of an approach to add support for TLS PSK based on the work in #17074. I've bumped the other thread a few times, but figured I would move the discussion into my actual implementation here.

There was some discussion on the different possible approaches and I believe what I have implemented here follows @dpgeorge 's suggestion in 17074. How does it look and does this direction seem good? If so, I can finalize the paperwork to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
extmod Relates to extmod/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keenanjohnson @dpgeorge
0