zephyr: Allow pins to support both hard and soft interrupts. #16916
Conversation
Signed-off-by: Daniel Campora <danicampora@gmail.com>
|
This looks quite useful, thanks! And the change seems to be rather simple at first glance. Have you tested this on hardware? |
|
@jonnor yes, tested it on nRF52840 and nRF5340 |
|
@danicampora Thanks for contributing this fix. I want to double check, are you sure that Zephyr doesn't already support both hard and soft interrupts? Take a look at the implementation of If soft interrupts are already working, I think that it probably is still worth updating the comment in |
|
@projectgus yes you are right, they are already working, not sure how I missed that. Thanks for pointing it out. |
The comment is written in a way that makes it sound like all interrupts are hard IRQs. I'll submit a quick PR to update it. |
The Pin irq method has an option
hardparameter that us used to select if the IRQ callback will be called from interrupt context or not. At the moment in the Zephyr port this parameter value is saved but nothing is done with it and all pin interrupts are treated as hard. This PR presents a small change that allows to also handle interrupts in soft mode where the interrupt callback is called out of interrupt context allowing to execute bigger and less time sensitive routines.