8000 extmod/modlwip: Fix IGMP address type when IPv6 is enabled. by dpgeorge · Pull Request #16121 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

extmod/modlwip: Fix IGMP address type when IPv6 is enabled. #16121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

extmod/modlwip: Fix IGMP address type when IPv6 is enabled. #16121

merged 1 commit into from
Nov 4, 2024

Conversation

dpgeorge
Copy link
Member

Summary

This was missed in 628abf8

Fixes issue #16100.

Testing

Tested with PYBD-SF2 and Pico W. Multicast join works on v1.23.0 but not v1.24.0, but works again with this patch.

@dpgeorge dpgeorge added the extmod Relates to extmod/ directory in source label Oct 31, 2024
@dpgeorge dpgeorge requested a review from projectgus October 31, 2024 01:44
@dpgeorge dpgeorge mentioned this pull request Oct 31, 2024
Closed
@dpgeorge
Copy link
Member Author

Note: the bug was that, when IPv6 is enabled, the sizeof(ip_addr_t) is much larger than IPv4 size, which is what's needed for IGMP addressing.

@codecov Codecov
Copy link
codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (85053ad) to head (919756c).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16121   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         164      164           
  Lines       21345    21345           
=======================================
  Hits        21041    21041           
  Misses        304      304

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@projectgus projectgus linked an issue Oct 31, 2024 that may be closed by this pull request
Multicast Group Join Fails with ValueError from setsockopt() on v1.24.0 #16100
Closed
@dpgeorge
extmod/modlwip: Fix IGMP address type when IPv6 is enabled.
919756c 
This was missed in 628abf8.  The the bug
was that, when IPv6 is enabled, the `sizeof(ip_addr_t)` is much larger than
IPv4 size, which is what's needed for IGMP addressing.

Fixes issue micropython#16100.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the extmod-modlwip-fix-igmp-addr-type branch from 0e44fa1 to 919756c Compare November 4, 2024 02:13
@dpgeorge dpgeorge merged commit 919756c into micropython:master Nov 4, 2024
60 checks passed
@dpgeorge dpgeorge deleted the extmod-modlwip-fix-igmp-addr-type branch November 4, 2024 02:17
@dpgeorge dpgeorge added this to the release-1.24.1 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@projectgus projectgus projectgus approved these changes

Assignees
No one assigned
Labels
extmod Relates to extmod/ directory in source
Projects
None yet
Milestone
release-1.24.1
Development

Successfully merging this pull request may close these issues.

Multicast Group Join Fails with ValueError from setsockopt() on v1.24.0
2 participants
@dpgeorge @projectgus
0