8000 extmod/mbedtls: Optimise the DER certificate parsing fix. by projectgus · Pull Request #15657 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

extmod/mbedtls: Optimise the DER certificate parsing fix. #15657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2024
Merged

extmod/mbedtls: Optimise the DER certificate parsing fix. #15657

merged 1 commit into from
Aug 26, 2024

Conversation

@projectgus
Copy link
Contributor
@projectgus projectgus commented Aug 14, 2024

Summary

Small code size and binary size optimisation for the fix merged in #14385.

Testing

$ openssl req -x509 -newkey rsa:2048 -keyout rsa_key.pem -out rsa_cert.pem -days 3650 -nodes -subj '/CN=micropython.local/O=MicroPython/C=AU'
$ mpremote cp rsa_key.pem rsa_cert.pem
$ mpremote repl

>>> import io,ssl
>>> ssl.wrap_socket(io.BytesIO(), key="rsa_key.pem", cert="rsa_key.pem", do_handshake=False)
<SSLSocket>

This work was funded through GitHub Sponsors.

@projectgus projectgus added the extmod Relates to extmod/ directory in source label Aug 14, 2024
@projectgus projectgus requested a review from dpgeorge August 14, 2024 00:55
@github-actions
Copy link
github-actions bot commented Aug 14, 2024

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +8 +0.001% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@codecov
Copy link
codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.43%. Comparing base (706e09d) to head (b82c9ca).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15657   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         163      163           
  Lines       21290    21295    +5     
=======================================
+ Hits        20956    20961    +5     
  Misses        334      334

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dpgeorge
dpgeorge reviewed Aug 14, 2024
View reviewed changes
@projectgus projectgus force-pushed the opt/mbedtls_pem_parse branch from 22929d0 to a348bc5 Compare August 14, 2024 01:16
@dpgeorge
Copy link
Member
dpgeorge commented Aug 14, 2024

@peterzuger FYI, this should be just an optimisation of your commit.

@projectgus projectgus force-pushed the opt/mbedtls_pem_parse branch from a348bc5 to 74c26e2 Compare August 14, 2024 04:37
@dpgeorge dpgeorge force-pushed the opt/mbedtls_pem_parse branch from 74c26e2 to 64b8f47 Compare August 26, 2024 02:46
@projectgus @dpgeorge
extmod/modtls_mbedtls: Optimise the DER certificate parsing fix.
b82c9ca 
Small code size and binary size optimisation for the fix merged in
4d6d849.

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <angus@redyak.com.au>
@dpgeorge dpgeorge force-pushed the opt/mbedtls_pem_parse branch from 64b8f47 to b82c9ca Compare August 26, 2024 02:48
@dpgeorge dpgeorge merged commit b82c9ca into micropython:master Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees

No one assigned

Labels

extmod Relates to extmod/ directory in source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@projectgus @dpgeorge
0