8000 nrf/Makefile: Fix GCC_VERION regex. by andrewleech · Pull Request #15553 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

nrf/Makefile: Fix GCC_VERION regex. #15553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

nrf/Makefile: Fix GCC_VERION regex. #15553

merged 1 commit into from
Jul 31, 2024

Conversation

andrewleech
Copy link
Contributor

@andrewleech andrewleech mentioned this pull request Jul 26, 2024
Merged
agatti
agatti reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor
@agatti agatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using a regex and invoking sed, how about something like $(shell $(CC) -dumpversion)? It's been available in GCC since pretty much forever as far as I know.

@andrewleech
Copy link
Contributor Author

how about something like $(shell $(CC) -dumpversion)

Oh that's an easy yes! Thanks, not sure why I couldn't find that when I searched initially. Stack overflow let me down ;-)

Cheers, I'll update this shortly as such.

@pi-anl @dpgeorge
nrf/Makefile: Fix GCC_VERSION check.
70a7e0f 
Previously it was truncating the first digit of the version if the major
number had more than one digit.

Signed-off-by: Andrew Leech <andrew@alelec.net>
@dpgeorge dpgeorge merged commit 70a7e0f into micropython:master Jul 31, 2024
7 checks passed
@andrewleech andrewleech deleted the nrf_arm_version branch August 23, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatti agatti agatti left review comments

Assignees
No one assigned
Labels
port-nrf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewleech @agatti @dpgeorge @pi-anl
0