renesas-ra/usb: Use interrupt rather than polling for usb task. #15550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewleech I finally had a chance to test this and USB is working fine with this change. |
|
That's great thanks @iabdalkader |
6 tasks
Most ports using TinyUSB now schedule the USB tasks from the USB interrupt. This commit updates the renesas-ra port to use this new pattern. Signed-off-by: Andrew Leech <andrew@alelec.net>
39c32aa to
a2475ee
Compare
|
Thanks @andrewleech, it's good to make all TinyUSB ports use the same mechanism. And thanks to @iabdalkader for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most ports using TinyUSB now service the usb tasks from the usb interrupt. Based on issues reported in #14462 (comment) I noticed the renesas port was still using the older polling pattern for this.
A quick test on a "EK-RA4W1 with usb cable patched on" I've got showed that the interrupt wrap approach appears to work correctly here, so submitted this change.
Testing
So far just flashing this change to "EK-RA4W1 with usb cable patched on" and tested that repl is still available in mpremote
The board I have uses the renesas full-speed peripheral, this change has not been tested on renesas board with high-speed usb.