8000 extmod/asyncio: Remove non-working Stream __aenter__/__aexit__ methods. by dpgeorge · Pull Request #13234 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

extmod/asyncio: Remove non-working Stream __aenter__/__aexit__ methods. #13234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

extmod/asyncio: Remove non-working Stream __aenter__/__aexit__ methods. #13234

merged 1 commit into from
Dec 20, 2023

Conversation

dpgeorge
Copy link
Member

It looks like these never worked and there are no tests for this functionality. Furthermore, CPython doesn't support this.

Fixes #12995.

@dpgeorge
extmod/asyncio: Remove non-working Stream __aenter__/__aexit__ methods.
f46269a 
It looks like these never worked and there are no tests for this
functionality.  Furthermore, CPython doesn't support this.

Fixes micropython#12995.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge added the extmod Relates to extmod/ directory in source label Dec 20, 2023
@dpgeorge dpgeorge mentioned this pull request Dec 20, 2023
Closed
@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:  -288 -0.036% standard[incl -128(data)]
      stm32:   -72 -0.018% PYBV10
     mimxrt:   -80 -0.022% TEENSY40
        rp2:   -80 -0.024% RPI_PICO
       samd:   -76 -0.029% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@codecov Codecov
Copy link
codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6d6308) 98.40% compared to head (f46269a) 98.40%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #13234   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         159      159           
  Lines       21075    21075           
=======================================
  Hits        20738    20738           
  Misses        337      337

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgeorge dpgeorge merged commit f46269a into micropython:master Dec 20, 2023
@dpgeorge dpgeorge deleted the extmod-asyncio-stream-remove-broken-context-manager branch December 20, 2023 06:17
@dhalbert dhalbert mentioned this pull request Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
extmod Relates to extmod/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asyncio stream.py: Is async context manager code correct?
1 participant
@dpgeorge
0