samd: Refactor to use shared tinyusb, implement unique id (with cross-port refactor) #12908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a merge conflict between this PR and #12846 as they make some of the same changes. If either merges, I'll rebase the other. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12908 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 158 158
Lines 20978 20978
=======================================
Hits 20649 20649
Misses 329 329 ☔ View full report in Codecov by Sentry. |
|
This can be rebased now. |
ec9be41 to
c8d6af4
Compare
|
Rebased, updated the size numbers. |
Functionality and code size don't really change, but removes port-specific code in favour of shared code. (The MSC implemented in shared/tinyusb depends on some functions in the pico-sdk, so this change doesn't make this available for samd.) This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>
Change the rp2 and renesas-ra ports to use the helper function. Saves copy-pasta, at the small cost of one more function call in the firmware (if not using LTO). This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>
Replaces the previous all-zeroes "TODO" serial number. Requires refactoring the low-level unique_id routine out from modmachine.c. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>
c8d6af4 to
8b1980a
Compare
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three related changes for tinyusb on samd port (including a refactor that also covers rp2 and renesas-ra):
machine.unique_id()implementation. Previously this was all-zeroes// TODO.Can split into two PRs if that is easier to review.
Tested on a Seeed WIO Terminal and a Seeed XIAO.
Code size impacts: