8000 Fix Firefox dnd highlighting bug by microbit-robert · Pull Request #611 · microbit-foundation/python-editor-v3 · GitHub
[go: up one dir, main page]

Skip to content

Fix Firefox dnd highlighting bug #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Conversation

microbit-robert
Copy link
Collaborator

Default to transition: none on cm-line class to remove latent dnd highlighting.

Closes #537.

@github-actions
Copy link

Preview build will be at
https://review-python-editor-next.microbit.org/highlight-dnd/

@microbit-robert
Copy link
Collaborator Author

Left as a draft for discussion.

@microbit-matt-hillsdon
Copy link
Collaborator

Has a conflict now from the CM upgrade.

@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as ready for review February 22, 2022 15:58
Copy link
Collaborator
@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand the differing behaviour in FF in the first place, but this fixes it and seems low risk.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 3c9bb17 into main Feb 22, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the highlight-dnd branch February 22, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert code highlighting bug in Firefox
2 participants
0