Signature help fix tweak. #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close the signature help while we know the view is still good. Alternatively we could cancel the timeout but this is OK too. I can't see simple API to check that a view is still good to interact with after an async step.
8000
|
Preview build will be at |
|
We've seen crashes where this dispatch results in CM accessing a contentEditable field that's no longer there. I assume some blur scenario that results in a change of editor but I wasn't able to repro even with a manually added timeout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to th
2F61
e code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the signature help while we know the view is still good. Alternatively we could cancel the timeout but this is OK too. I can't see simple API to check that a view is still good to interact with after an async step.