10BC0 Test tab out of editor scenarios by microbit-matt-hillsdon · Pull Request #1051 · microbit-foundation/python-editor-v3 · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@microbit-matt-hillsdon
Copy link
Collaborator

Try to make the existing focus tests simpler to follow.
Create a method to assert focus that we can use to create more such assertions.

Somehow running directly after type causes issues. We don't need to do
that though.
@github-actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/focus-tests/

@microbit-matt-hillsdon
Copy link
Collaborator Author

Latest failure was in the CF invalidation. Re-running.

@microbit-matt-hillsdon
Copy link
Collaborator Author

Passed this time but queuing again for confirmation as I hit various flakiness when writing (though not with the latest code).

@microbit-matt-hillsdon
Copy link
Collaborator Author

Passed this time but queuing again for confirmation as I hit various flakiness when writing (though not with the latest code).

All looks good.

Copy link
Collaborator
@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit bb11599 into main Oct 25, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the focus-tests branch October 25, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0