Translation sync to add Polish #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -158,6 +158,8 @@ async function loadStringsFromJsonFile(locale: string): Promise<StringLookupMap | |||
| return (await import(/* webpackChunkName: "ja" */ './simplified.nls.ja.json')).default; | |||
| case 'ko': | |||
| return (await import(/* webpackChunkName: "ko" */ './simplified.nls.ko.json')).default; | |||
| case 'pl': | |||
| return (await import(/* webpackChunkName: "nl" */ './simplified.nls.pl.json')).default; | |||
There was a problem hiding this comment.
Suggested change
| return (await import(/* webpackChunkName: "nl" */ './simplified.nls.pl.json')).default; | |
| return (await import(/* webpackChunkName: "pl" */ './simplified.nls.pl.json')).default; |
There was a problem hiding this comment.
Well that would have been unfortunate! I was completely convinced by seeing the language change from English...
There was a problem hiding this comment.
Oh, I see it likely makes no difference...
There was a problem hiding this comment.
1fc5f9b
and updated in the editor PR too
There was a problem hiding this comment.
Looks like they just get bundled together?
microbit-robert
requested changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.