Re-enabled builds for PyTorch 2.3 and 2.4 on Windows #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc3af9a to
9e46cc3
Compare
Luthaf
commented
Jul 22, 2024
Comment on lines
+231
to
+239
| if sys.platform == "win32": | ||
| # On Windows, starting with PyTorch 2.3, the file shm.dll in torch has a | ||
| # dependency on mkl DLLs. When building the code using pip build isolation, pip | ||
| # installs the mkl package in a place where the os is not trying to load | ||
| # | ||
| # This is a very similar fix to https://github.com/pytorch/pytorch/pull/126095, | ||
| # except only applying when importing torch from a build-isolation virtual | ||
| # environment created by pip (`python -m build` does not seems to suffer from | ||
| # this). |
There was a problem hiding this comment.
We'll need to keep this hack around until pytorch/pytorch#131340 is merged, released, and available on all torch releases we support.
91c354a to
334efd8
Compare
Merged
334efd8 to
ecd2717
Compare
frostedoyster
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it says on the tin! PyTorch 2.3.1 should have fixed the previous issue on Windows.
Contributor (creator of pull-request) checklist
Reviewer checklist
📚 Download documentation preview for this pull-request
⚙️ Download Python wheels for this pull-request (you can install these with pip)