E52F Allow passing arrays of string as sqlInitialParameters in InteractiveQuestion by lorem--ipsum · Pull Request #67282 · metabase/metabase · GitHub
[go: up one dir, main page]
Skip to content

Allow passing arrays of string as sqlInitialParameters in InteractiveQuestion #67282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lorem--ipsum wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow passing arrays of string as sqlInitialParameters in InteractiveQuestion #67282

lorem--ipsum wants to merge 2 commits into from
+194 −11

Conversation

@lorem--ipsum
Copy link
Contributor
@lorem--ipsum lorem--ipsum commented Dec 19, 2025 •
edited by github-actions bot
Loading
closes #64673

Closes EMB-912: [SDK] Use multiple values as initialSqlParameters

Description

Add a bit of parsing for initialSqlParameters if the underlyign parameter accepts multiple selection.

How to verify

  1. make a SQL question that accepts a field filter variable (see https://www.metabase.com/docs/latest/questions/native-editor/field-filters) and make it accept multiple values
  2. Open it through the SDK InteractiveQuestion with initialSqlParameters set to an array like follows:
<InteractiveQuestion
  initialSqlParameters={{
      category: ["Gizmo", "Doohickey"],
    }}
  questionId={113}
></InteractiveQuestion>

Checklist

  • Tests have been added/updated to cover changes in this PR

@lorem--ipsum lorem--ipsum added the backport Automatically create PR on current release branch on merge label Dec 19, 2025
@github-actions
Copy link
Contributor
github-actions bot commented Dec 19, 2025 •
edited
Loading

e2e tests failed on dcd3e35ed845de859921629f3d7636cc18f6086c-2

e2e test run

File Test Name
tenant-users-sidecar.cy.spec.ts scenarios > sidecar > tenant users > the tenant collection should be called 'Our data' and be read only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lorem--ipsum lorem--ipsum

Labels

backport Automatically create PR on current release branch on merge .Team/Embedding

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SDK] Use multiple values as initialSqlParameters

2 participants

@lorem--ipsum
0