Convert LoadingAndErrorWrapper to TS
#52475
Conversation
6a89727 to
c8a0242
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff ee22e28...bd077f5. No notifications. |
c8a0242 to
b10c098
Compare
| @@ -26,19 +26,6 @@ describe("LoadingAndErrorWrapper", () => { | |||
| ).not.toThrow(); | |||
| }); | |||
|
|
|||
| it("should display a given scene during loading", () => { | |||
There was a problem hiding this comment.
I removed loadingScenes and sceneIndex from the main component - we don't seem be using them anywhere in the app other than here.
|
fwiw there's a I have a backburnered project to overhaul this component and the |
Ah, gotcha. I think for the bug I'm trying to solve, the types would be really nice (if not sorely needed) on this and I don't think it's too much work |
|
This change is part of the following stack: Change managed by git-spice. |
|
|
||
| interface LoadingAndErrorWrapperProps { | ||
| loading?: boolean; | ||
| error?: any; |
There was a problem hiding this comment.
not sure if using unknown might make more sense for errors, since you could then cast it to any error types
c16cdc2 to
74f81b7
Compare
|
🚀 This should also be released by v0.53 |
backporting because this is part of an SDK bug fix
This will help me with the type checking of Start looking for all instances of ExplicitSize findDOMNode.
I also converted the default imports/exports to named ones using grep so that's why this looks so big. The main file of concern is here
Nothing has changed, CI should pass as normal.