Run tests only with a single http client #758
Conversation
## Walkthrough
The GitHub Actions workflows were simplified by removing the HTTP client matrix and all related conditional steps for switching HTTP client dependencies. Dedicated jobs for testing with Guzzle 6 on PHP 7.4 were deleted. In `composer.json`, the Symfony HTTP client was added as a development dependency and suggestion, while Guzzle was removed from development requirements.
## Changes
| File(s) | Change Summary |
|-----------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------|
| `.github/workflows/meilisearch-beta-tests.yml`,<br>`.github/workflows/pre-release-tests.yml`,<br>`.github/workflows/tests.yml` | Removed HTTP client matrix and conditional dependency switching; deleted `test_php_7_guzzle_6` job. |
| `composer.json` | Added Symfony HTTP client as a dev dependency and suggestion; removed Guzzle from dev dependencies. |
## Suggested labels
`enhancement`
## Poem
> A hop through the workflows, light and neat,
> Matrixes trimmed, no more client swap feat.
> Symfony hops in, Guzzle takes a bow,
> Simpler tests run—much lighter now!
> With every commit, the garden grows bright,
> 🐇 Cheers to clean code and a future so light!📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
5181d8a to
ff155a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
- Coverage 90.74% 89.78% -0.97%
==========================================
Files 52 59 +7
Lines 1340 1449 +109
==========================================
+ Hits 1216 1301 +85
- Misses 124 148 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/pre-release-tests.yml (1)
42-50: Clean up commented-out HTTP client matrix lines
Since support for multiple HTTP clients has been removed, you can streamline this workflow by deleting the now-unused commented blocks undermatrix.http-clientandexclude. This will make the YAML more maintainable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/meilisearch-beta-tests.yml(1 hunks).github/workflows/pre-release-tests.yml(1 hunks).github/workflows/tests.yml(1 hunks)composer.json(1 hunks)
🔇 Additional comments (2)
composer.json (2)
38-42: Ensure suggested HTTP clients align with current strategy
We’ve commented out multi-client testing and standardized on Symfony HTTP client in CI/development. Please verify that thesuggestsection still accurately reflects the clients you intend to support (e.g., if Guzzle remains supported, document that as optional). Also consider updating the README to highlight Symfony HTTP client as the primary recommendation.
49-52: Standardize development dependencies on Symfony HTTP client
Removal ofguzzlehttp/guzzlefromrequire-devand addition ofsymfony/http-clientcorrectly aligns your dev dependencies with the CI changes. This ensures tests and discovery will pick up the Symfony client by default.
ff155a4 to
7493ee5
Compare
There was a problem hiding this comment.
I support this change, but would prefer to have feedback from @brunoocasali too before moving forward.
7493ee5 to
23f43c5
Compare
23f43c5 to
0078a8c
Compare
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
Why?
PR checklist
Please check if your PR fulfills the following requirements:
Summary by CodeRabbit