Fix getRed/setRed example to use HSL→RGB conversion #42086
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview URLs (comment last updated: 2025-11-24 16:51:22) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42059
Description
Updates the Color class example so that getRed() and setRed() correctly operate on the red
channel after the internal representation was changed from RGB to HSL. Previously, the example
incorrectly accessed values[0], which is the hue component in HSL.
Motivation
The documentation states that the internal storage is changed to HSL using rgbToHSL().
Therefore, getRed() and setRed() must convert HSL → RGB when reading or modifying the red channel.
This PR aligns the example with the encapsulation explanation and corrects the logic.
Additional details