8000 fix(learn): Use input type=text instead of prompt() due to missing `allow-modals` attr by bsmth · Pull Request #38026 · mdn/content · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(learn): Use input type=text instead of prompt() due to missing allow-modals attr #38026

Closed
wants to merge 2 commits into from
Closed

fix(learn): Use input type=text instead of prompt() due to missing allow-modals attr #38026

wants to merge 2 commits into from

Conversation

bsmth
Copy link
Member
@bsmth bsmth commented Feb 7, 2025

Description

The current example is broken due to:

Ignored call to 'prompt()'. The document is sandboxed, and the 'allow-modals' keyword is not set.

Motivation

We can use an input element here instead.

Related issues and pull requests

@bsmth bsmth requested a review from a team as a code owner February 7, 2025 15:13
@bsmth bsmth requested review from pepelsbey and removed request for a team February 7, 2025 15:13
@github-actions github-actions bot added the Content:Learn Learning area docs label Feb 7, 2025
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Feb 7, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Feb 7, 2025 •
edited
Loading

Preview URLs

(comment last updated: 2025-02-07 15:15:26)

@bsmth
Copy link
Member Author
bsmth commented Feb 20, 2025

Closing in favor of #38253

@bsmth bsmth closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Learn Learning area docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bsmth
0