8000 Adds property mockConsoleOutput on tests for laravel 5.7 compatiblity by manelgavalda · Pull Request #420 · mdbootstrap/adminlte-laravel · GitHub
[go: up one dir, main page]
Skip to content

Adds property mockConsoleOutput on tests for laravel 5.7 compatiblity #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2020
Merged

Adds property mockConsoleOutput on tests for laravel 5.7 compatiblity #420

merged 2 commits into from
Mar 7, 2020

Conversation

manelgavalda
Copy link
Collaborator
@manelgavalda manelgavalda commented Mar 7, 2020 •
edited
Loading

Description

Adds the mockConsoleOutput public property to false, so the Artisan output is correctly shown and makes the tests work again with Laravel 5.7.

Motivation and context

Adds Laravel 5.7 compatibility.

How has this been tested?

It is part of the official documentation: https://laravel.com/docs/5.7/upgrade#upgrade-5.7.0

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@manelgavalda manelgavalda changed the title Add property mockConsoleOutput on tests for laravel 5.7 compatiblity Adds property mockConsoleOutput on tests for laravel 5.7 compatiblity Mar 7, 2020
@manelgavalda manelgavalda merged commit 3bae062 into mdbootstrap:master Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manelgavalda
0