Removes DetectsApplicationNamespace trait for L7 compat #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While this is hardly a proper patch for full Laravel 7 support, it does fix the breakage introduced by the deprecation of the
DetectsApplicationNamespacetrait in Laravel 7.Motivation and context
If you started using this package in the Laravel 5.x days, and you want it to use it with Laravel 6.x, you can get pretty far with
composertricks like:e.g. basically fooling the other packages that an older version of Laravel is installed.
However, the buck stops if there are breaking changes, which is the case with Laravel 7: the DetectsApplicationNamespace which was announced in L6 was going to be deprecated, is now gone.
So if you still want to keep on using this package in the age of L7, you will need to remove said trait and replace the function call with whatever logic the trait provided.
How has this been tested?
Not very. I have a codebase that is on L6 that still uses this package. Today, L7 was released and this came up. So I did a quick fix and made it work with L7.
So this is untested. Your mileage may vary.
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!