8000 AddressNotFoundError: add .network by illes · Pull Request #130 · maxmind/GeoIP2-python · GitHub
[go: up one dir, main page]
Skip to content

AddressNotFoundError: add .network #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2022
Merged

AddressNotFoundError: add .network #130

merged 3 commits into from
Jun 21, 2022

Conversation

illes
Copy link
Contributor
@illes illes commented Jun 17, 2022

See README.rst snippet for example usage.

@illes illes force-pushed the illes/error-network branch from 0624627 to 79d0308 Compare June 17, 2022 09:04
oschwald
oschwald requested changes Jun 17, 2022
View reviewed changes
Copy link
Member
@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Eventually, it would be nice to update maxminddb to provide an iterator over a network, but even if we do that, have the network in the exception may be useful in other cases.

Would you mind adding a unit test as well? Thanks!

@illes
Copy link
Contributor Author
illes commented Jun 20, 2022

@oschwald , added unit test in fixup commit

@illes illes requested a review from oschwald June 20, 2022 08:36
@oschwald oschwald merged commit 845eaca into maxmind:main Jun 21, 2022
@oschwald
Copy link
Member

4.6.0 was released with this change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschwald oschwald oschwald approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illes @oschwald
0