This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Add support for postgres interval type as Period #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,8 @@ trait DatabaseTestHelper { | |||
|
|
|||
| def defaultConfiguration = new Configuration( | |||
| port = databasePort, | |||
| username = "postgres", | |||
| username = "netty_driver_test", | |||
| password = Some("netty"), | |||
There was a problem hiding this comment.
Why change the database details here?
|
Sorry, didn't mean to commit that change. Removed. |
|
Looks great, can you rebase this against master so I can merge? |
|
Rebased. |
Internally postgres stores (months, days, seconds), for which it may make sense to use Duration instead. Unfortunately, it externally presents an interface that looks more like Period, so this approach makes parsing easier.
mauricio
added a commit
that referenced
this pull request
Nov 2, 2013
Add support for postgres interval type as Period
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally postgres stores (months, days, seconds), for which it may make sense to use Duration instead. However, it externally presents an interface that looks more like Period, so this approach makes parsing easier, and allows the user to then convert to Durations as they see fit. If the binary interface is used eventually, this decision perhaps should be revisited. Duration is supported on encode. The lack of sub-millisecond precision is unfortunate, but issue #25 covers that. Some negative values are not supported correctly in some formats due to incompatibilities in the joda Period parser.