8000 Add an Annulus patch class by astromancer · Pull Request #9888 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Add an Annulus patch class #9888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 15, 2021
Merged

Add an Annulus patch class #9888

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e4697e7
add Annulus patch
astromancer Nov 22, 2017
a05fb1e
'add Annulus patch for making elliptical annuli'
astromancer Nov 30, 2017
ecd6083
docstring fixes
astromancer Jan 7, 2018
bd3f498
better str repr
astromancer Jan 8, 2018
e1f863e
add what's new entry
astromancer Jan 8, 2018
ad81c4b
add image test
astromancer Jan 8, 2018
7bc465a
tweaks
astromancer Jan 9, 2018
83047be
update docstring
astromancer Mar 3, 2021
32a5daf
add whats new
astromancer Mar 3, 2021
9f12372
cleanup test
astromancer Mar 3, 2021
05cd23a
flake8
astromancer Mar 3, 2021
a5cf0c5
simplify hstack
astromancer Mar 10, 2021
d2fc81a
Apply suggestions from code review
astromancer Mar 12, 2021
23bd2da
attr setters/getters
astromancer Mar 14, 2021
f0392f6
flake8
astromancer Mar 14, 2021
0882ed8
update setters
astromancer Mar 27, 2021
0ba1cba
test setters and string repr
astromancer Mar 27, 2021
b21d4ee
update docs
astromancer Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
'add Annulus patch for making elliptical annuli'
  • Loading branch information
@astromancer
astromancer committed Mar 3, 2021
commit a05fb1e228eb56aa8a00431da4143c253ae1fdfe
5 changes: 1 addition & 4 deletions lib/matplotlib/patches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1608,8 +1608,6 @@ def __init__(self, xy, r, width, angle=0.0, **kwargs):
self.width = width
self.angle = angle
self._path = None
# Note: This cannot be calculated until this is added to an Axes
self._patch_transform = transforms.IdentityTransform()

def _transform_verts(self, verts, a, b):
center = (self.convert_xunits(self.center[0]),
Expand All @@ -1624,11 +1622,10 @@ def _transform_verts(self, verts, a, b):
return tr.transform(verts)

def _recompute_path(self):

# circular arc
Copy link
Member

Choose a reason for hiding this comment

< 90A6 p class="mb-3"> The reason will be displayed to describe this comment to others. Learn more.

This looks great. However, do we understand why codecov is confused by this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have given up trying to understand codecov. Above it warns on a line that's part of a docstring.

arc = Path.arc(0, 360)

# annulus needs to draw the outer ring
# annulus needs to draw an outer ring
# followed by a reversed and scaled inner ring
a, b, w = self.a, self.b, self.width
v1 = self._transform_verts(arc.vertices, a, b)
Expand Down
0