8000 API: do not truncate svg size to integer points by tacaswell · Pull Request #9817 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

API: do not truncate svg size to integer points #9817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2017
Merged

API: do not truncate svg size to integer points #9817

merged 2 commits into from
Nov 20, 2017

Conversation

tacaswell
Copy link
Member

PR Summary

closes #9815

This will svgs slightly bigger.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v2.2 milestone Nov 19, 2017
anntzer
anntzer approved these changes Nov 19, 2017
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional on tests.

dstansby
dstansby approved these changes Nov 19, 2017
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if/when tests pass

@anntzer
Copy link
Contributor
anntzer commented Nov 20, 2017

thanks

@anntzer anntzer merged commit 7ddc73a into matplotlib:master Nov 20, 2017
@tacaswell tacaswell deleted the fix_svg_size branch November 20, 2017 02:29
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
@tacaswell tacaswell mentioned this pull request Jul 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

svg backend truncates output size to integer, which it doesn't need to (and pdf backend doesn't)
4 participants
@tacaswell @anntzer @dstansby @QuLogic
0