-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
ENH: support np.datenum64 in dates.py #9779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -243,6 +243,27 @@ def _to_ordinalf(dt): | |
_to_ordinalf_np_vectorized = np.vectorize(_to_ordinalf) | ||
|
||
|
||
def _dt64_to_ordinalf(d): | ||
""" | ||
Convert `numpy.datetime64` or an ndarray of those types to Gregorian | ||
date as UTC float. Roundoff is via float64 precision. Practically: | ||
microseconds for dates between 290301 BC, 294241 AD, milliseconds for | ||
larger dates (see `numpy.datetime64`). Nanoseconds aren't possible | ||
because we do times compared to ``0001-01-01T00:00:00`` (plus one day). | ||
""" | ||
|
||
# the "extra" ensures that we at least allow the dynamic range out to | ||
# seconds. That should get out to +/-2e11 years. | ||
extra = d - d.astype('datetime64[s]') | ||
extra = extra.astype('timedelta64[ns]') | ||
t0 = np.datetime64('0001-01-01T00:00:00').astype('datetime64[s]') | ||
dt = (d.astype('datetime64[s]') - t0).astype(np.float64) | ||
dt += extra.astype(np.float64) / 1.0e9 | ||
dt = dt / SEC_PER_DAY + 1.0 | ||
|
||
return dt | ||
|
||
|
||
def _from_ordinalf(x, tz=None): | ||
""" | ||
Convert Gregorian float of the date, preserving hours, minutes, | ||
|
@@ -354,12 +375,13 @@ def date2num(d): | |
|
||
Parameters | ||
---------- | ||
d : :class:`datetime` or sequence of :class:`datetime` | ||
d : :class:`datetime` or :class:`numpy.datetime64`, or sequences of | ||
these classes. | ||
|
||
Returns | ||
------- | ||
float or sequence of floats | ||
Number of days (fraction part represents hours, minutes, seconds) | ||
Number of days (fraction part represents hours, minutes, seconds, ms) | ||
since 0001-01-01 00:00:00 UTC, plus one. | ||
|
||
Notes | ||
|
@@ -368,6 +390,10 @@ def date2num(d): | |
Gregorian calendar is assumed; this is not universal practice. | ||
For details see the module docstring. | ||
""" | ||
|
||
if ((isinstance(d, np.ndarray) and np.issubdtype(d.dtype, np.datetime64)) | ||
or isinstance(d, np.datetime64)): | ||
return _dt64_to_ordinalf(d) | ||
if not cbook.iterable(d): | ||
return _to_ordinalf(d) | ||
else: | ||
|
@@ -488,8 +514,8 @@ def drange(dstart, dend, delta): | |
*dend* are :class:`datetime` instances. *delta* is a | ||
:class:`datetime.timedelta` instance. | ||
""" | ||
f1 = _to_ordinalf(dstart) | ||
f2 = _to_ordinalf(dend) | ||
f1 = date2num(dstart) | ||
f2 = date2num(dend) | ||
step = delta.total_seconds() / SEC_PER_DAY | ||
|
||
# calculate the difference between dend and dstart in times of delta | ||
|
@@ -504,7 +530,7 @@ def drange(dstart, dend, delta): | |
dinterval_end -= delta | ||
num -= 1 | ||
|
||
f2 = _to_ordinalf(dinterval_end) # new float-endpoint | ||
f2 = date2num(dinterval_end) # new float-endpoint | ||
return np.linspace(f1, f2, num + 1) | ||
|
||
### date tickers and formatters ### | ||
|
@@ -1630,5 +1656,6 @@ def default_units(x, axis): | |
return None | ||
|
||
|
||
units.registry[np.datetime64] = DateConverter() | ||
units.registry[datetime.date] = DateConverter() | ||
units.registry[datetime.datetime] = DateConverter() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason this isn't done with base/time/timenp being pytest fixtures and the test parameterized or split into two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I can understand this, and I have no idea what a pytest fixture is. Is there an advantage to doing something more obscure than a simple
assert
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only cause you're repeating yourself a lot so it's hard to tell what the specific tests are. Factoring out common features into a fixture means you can make two tests that are uniquely named for the things they're testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it. OTOH, I find some of the tests aren't very easy to follow. Sometime verbosity is a good thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, happy to take suggestions, but I find the uses of fixtures in the existing tests makes for pretty obfuscated code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shrugs can agree on that somewhat, either way it's not something I'd hold the PR up on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I didn't mean to say I wasn't willing to learn, just that I don't get it... More than happy if you wanted to push a change or give me some pseudo code to get it to work... Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing your reply (the embedded ones seem to not pop up as notifications), and will totally try to remember your suggestion for the future. I should have been way clearer on what I wanted and given you an example. :/