8000 MNT: Make sure AppVeyor fails if tests fail by dopplershift · Pull Request #9773 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MNT: Make sure AppVeyor fails if tests fail #9773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 23, 2017
Merged

MNT: Make sure AppVeyor fails if tests fail #9773

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5572869
MNT: Clean up AppVeyor a bit
dopplershift Nov 13, 2017
9c34260
Make sure AppVeyor exits if test script fails
dopplershift Nov 14, 2017
84a1c0d
MNT: Fix test failures from string representations
dopplershift Nov 17, 2017
5edaadb
MNT: Remove conda recipe
dopplershift Nov 20, 2017
16512ee
MNT: Remove AppVeyor workaround for Python 3.4
dopplershift Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
< 8000 div class="container-md js-file-filter-blankslate" data-target="diff-file-filter.blankslate" hidden>

There are no files selected for viewing

9 changes: 4 additions & 5 deletions .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ install:
# https://github.com/matplotlib/matplotlib/issues/9176
- python -c "import sys; sys.exit(not (3,) < sys.version_info < (3,6,3))" && (
curl -sL https://github.com/python/cpython/pull/1224.patch |
patch -fsup 1 -d %CONDA_PREFIX% ) || ( set errorlevel= )
patch -fsup 1 -d %CONDA_PREFIX% ) || cmd /c "exit /b 0"

# Let the install prefer the static builds of the libs
- set LIBRARY_LIB=%CONDA_PREFIX%\Library\lib
Expand Down Expand Up @@ -134,10 +134,6 @@ test_script:
# tests
- echo The following args are passed to pytest %PYTEST_ARGS%
- python tests.py %PYTEST_ARGS%
# Generate a html for visual tests
- python tools/visualize_tests.py --no-browser
- pip install codecov
- codecov -e PYTHON_VERSION PLATFORM

after_test:
# After the tests were a success, build packages (wheels and conda)
Expand Down Expand Up @@ -174,8 +170,11 @@ artifacts:
type: zip

on_finish:
- pip install codecov
- codecov -e PYTHON_VERSION PLATFORM

on_failure:
# Generate a html for visual tests
- python tools/visualize_tests.py --no-browser
- echo zipping images after a failure...
- 7z a result_images.zip result_images\ | grep -v "Compressing"
Expand Down
5 changes: 4 additions & 1 deletion lib/matplotlib/tests/test_preprocess_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import re

import numpy as np
import pytest

from matplotlib import _preprocess_data
Expand Down Expand Up @@ -165,7 +166,9 @@ def test_function_call_with_pandas_data(func):
"""test with pandas dataframe -> label comes from data["col"].name """
pd = pytest.importorskip('pandas')

data = pd.DataFrame({"a": [1, 2], "b": [8, 9], "w": ["NOT", "NOT"]})
data = pd.DataFrame({"a": np.array([1, 2], dtype=np.int32),
"b": np.array([8, 9], dtype=np.int32),
"w": ["NOT", "NOT"]})

assert (func(None, "a", "b", data=data) ==
"x: [1, 2], y: [8, 9], ls: x, w: xyz, label: b")
Expand Down
0