Unify the three Qt5 embedding examples. #9599
Conversation
38c756d to
1fc660b
Compare
1fc660b to
9c508a7
Compare
... and modernize them a bit.
9c508a7 to
0b93410
Compare
|
examples/user_interfaces/embedding_in_qt4_wtoolbar_sgskip.py is nice because it shows you do not have to sub-class |
|
Good point. In fact the subclassing in the other example is completely unnecessary -- I'll move everything to the non-subclassing style... |
|
I wrote what is basically a completely new embedding example, which does not rely on subclassing the Canvas (that is totally unneeded, both here and in my experience), and still showcases having multiple canvases, including a dynamic one, and the corresponding toolbars. |
78fc096 to
e897855
Compare
|
Quite unrelated, but the 2nd canvas of the new example illustrates quite well the issue #9546 (annoying behavior with the busy cursor). |
|
I know... |
There was a problem hiding this comment.
The example works well on my machine.
I found the new_timer command mysterious. I wonder if either the pre-amble or this chunk of code could have a link to the docs where this is described?
A quick search didn't indicate where this functionality is documented, other than backed_bases.py. I guess we need a proper animation tutorial? I don't think any of the animation examples show the use of this function.
|
I think the backend docs need to be rewritten in general, it's somewhere on my todo list... |
|
Its fine, but do you need to do this versus just using the more vanilla Annimation module? |
|
Probably the examples predate the animation module, I essentially just copy-pasted and trimmed their general approach. May be nice to further modernize them to use animation but perhaps not in this PR? |
|
Yep, no problem. I'll merge... |
Backport PR #9599 on branch v2.1.0-doc
... and modernize them a bit.
PR Summary
PR Checklist