10000 FIX: provide __ne__ implementation for transforms in py2 by tacaswell · Pull Request #9468 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: provide __ne__ implementation for transforms in py2 #9468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2017
Merged

FIX: provide __ne__ implementation for transforms in py2 #9468

merged 1 commit into from
Oct 18, 2017

Conversation

tacaswell
Copy link
Member

Closes #9455

The issue is that due to != not defaulting to not a == b in
python2 (unlike python3) an internal check was failing and the y
ticks (aka the radial ticks) were being regenerated on every draw
and the alpha settings did not properly propagate.

This fix is a band-aid to make the behavior the same on all versions
of python.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell
FIX: provide __ne__ implementation for transforms in py2
b5bc6aa 
Closes matplotlib#9455

The issue is that due to `!=` not defaulting to `not a == b` in
python2 (unlike python3) an internal check was failing and the y
ticks (aka the radial ticks) were being regenerated on every draw
and the alpha settings did not properly propagate.

This fix is a band-aid to make the behavior the same on all versions
of python.
@tacaswell tacaswell added this to the v2.1.1 milestone Oct 18, 2017
@tacaswell tacaswell requested a review from QuLogic October 18, 2017 04:00
@WeatherGod
Copy link
Member

I wonder if this would result in a performance boost on py27?

@WeatherGod WeatherGod merged commit b03c7d2 into matplotlib:v2.1.x Oct 18, 2017
@tacaswell tacaswell deleted the fix_lpy_transforms_ne branch October 18, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeatherGod WeatherGod WeatherGod approved these changes

@dstansby dstansby dstansby approved these changes

@QuLogic QuLogic Awaiting requested review from QuLogic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @WeatherGod @dstansby
0