8000 Fix multiple unreferenced local variable warnings by Kojoley · Pull Request #9464 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix multiple unreferenced local variable warnings #9464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2017
Merged

Fix multiple unreferenced local variable warnings #9464

merged 1 commit into from
Oct 18, 2017

Conversation

Kojoley
Copy link
Member
@Kojoley Kojoley commented Oct 17, 2017

Complete list of these warnings:

    src/ft2font_wrapper.cpp(53): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(78): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(97): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(530): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(554): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(573): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(591): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(609): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(632): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(686): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(731): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(769): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(788): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(803): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(819): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(840): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(860): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(900): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(919): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(1071): warning C4101: 'e': unreferenced local variable
    src/ft2font_wrapper.cpp(1431): warning C4101: 'e': unreferenced local variable
    src/_image_wrapper.cpp(389): warning C4101: 'e': unreferenced local variable
    src/_image_wrapper.cpp(434): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(52): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(85): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(111): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(144): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(163): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(164): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(212): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(232): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(284): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(286): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(352): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(354): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(390): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(418): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(442): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(450): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(476): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(505): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(509): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(513): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(548): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(584): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(648): warning C4101: 'e': unreferenced local variable
    src/_path_wrapper.cpp(731): warning C4101: 'e': unreferenced local variable
    src/_contour_wrapper.cpp(68): warning C4101: 'e': unreferenced local variable
    src/_contour_wrapper.cpp(91): warning C4101: 'e': unreferenced local variable
    src/_contour_wrapper.cpp(118): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(91): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(122): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(134): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(151): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(179): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(265): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(289): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(316): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(391): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(423): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(435): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(446): warning C4101: 'e': unreferenced local variable
    lib/matplotlib/tri/_tri_wrapper.cpp(457): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(87): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(189): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(224): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(249): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(285): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(312): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(379): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(381): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(434): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(475): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(522): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(538): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(554): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(570): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(580): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(623): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(638): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(665): warning C4101: 'e': unreferenced local variable
    src/_backend_agg_wrapper.cpp(667): warning C4101: 'e': unreferenced local variable

anntzer
anntzer approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional on CI

@tacaswell
Copy link
Member

@Kojoley What does adding const in the try do here?

@tacaswell tacaswell added this to the v2.2 milestone Oct 18, 2017
@anntzer
Copy link
Contributor
anntzer commented Oct 18, 2017

http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Re-exception-ref

@tacaswell
Copy link
Member

Thanks @anntzer !

@dstansby dstansby merged commit 35d9605 into matplotlib:master Oct 18, 2017
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have 6BE8 an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kojoley @tacaswell @anntzer @QuLogic @dstansby
0