-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Clean up Appveyor config file #9319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e463697
to
3e16a3b
Compare
This should speed up appveyor by a little bit by removing 1 call to conda |
.appveyor.yml
Outdated
- conda install -c conda-forge --yes obvious-ci | ||
- conda config --set always_yes true | ||
- conda update --all | ||
- conda install anaconda-client=1.6.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line should be removed completely because previously anaconda-client
were upgraded to newer version by next line edited by you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I think that's because other versions of anadonda-client were breaking stuff? I can try removing the line and seeing what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only three lines are now executed under anaconda-client=1.6.3
conda config --prepend channels conda-forge
conda config --set show_channel_urls yes
conda config --set always_yes true
I do not think it does matter at all. So removing the line must not change anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were right. Some dependency hell is going here.
Okay, I've re-pinned anaconda-build and just added it to the line where everything is installed by conda. |
6b6c80b
to
1584511
Compare
1584511
to
38a367e
Compare
@@ -91,6 +89,7 @@ install: | |||
- echo %PYTHON_VERSION% %TARGET_ARCH% | |||
# pytest-cov>=2.3.1 due to https://github.com/pytest-dev/pytest-cov/issues/124 | |||
- pip install -q pytest "pytest-cov>=2.3.1" pytest-rerunfailures pytest-timeout pytest-xdist | |||
cycler pyparsing backports.functools-lru-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting these in this "quiet" pip section (instead of installing them along with Matplotlib later) should shave a few hundred useless lines from the output log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These packages will be installed automatically (#9673).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, but they're installed at the same time as Matplotlib
, which I don't think we want to have a quiet flag. Putting them here prevents pip spewing out a load of extra lines that aren't very useful for debugging.
I think this has all been covered by #9773 |
There have been a few problems with Appveyor recently; this attempts to clean up the initial stages of the testing a bit to help diagnose and speed up.
(nb. I'm pushing this one commit at a time to check they individually don't break the build)