8000 Errorbar bugfix by astromancer · Pull Request #9242 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Errorbar bugfix #9242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2017
Merged

Errorbar bugfix #9242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a2fb4e
add filter to cbook.safe_first_element to avoid returning masked values
astromancer Sep 27, 2017
91f9670
add filter to cbook.safe_first_element to avoid returning masked values
astromancer Sep 27, 2017
d0c5321
replace collections.Sized check with np.size to better handle masked …
astromancer Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
replace collections.Sized check with np.size to better handle masked … 
…elements in errorbar
  • Loading branch information
@astromancer
astromancer committed Sep 27, 2017
commit d0c5321a30ebd87213f4fea4d39c580f98742f3f
4 changes: 1 addition & 3 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import six
from six.moves import xrange, zip, zip_longest

from collections import Sized
import functools
import itertools
import math
Expand Down Expand Up @@ -3020,8 +3019,7 @@ def extract_err(err, data):
# special case for empty lists
if len(err) > 1:
fe = safe_first_element(err)
if (len(err) != len(data)
or isinstance(fe, Sized) and len(fe) > 1):
if (len(err) != len(data) or np.size(fe) > 1):
raise ValueError("err must be [ scalar | N, Nx1 "
"or 2xN array-like ]")
# using list comps rather than arrays to preserve units
Expand Down
2 changes: 1 addition & 1 deletion lib/matplotlib/cbook/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2311,7 +2311,7 @@ def safe_first_element(obj):
pass
raise RuntimeError("matplotlib does not support generators "
"as input")
return next(filter(lambda e: not np.ma.is_masked(e), iter(obj)))
return next(iter(obj))


def sanitize_sequence(data):
Expand Down
0