Don't update style-blacklisted rcparams in rc_* functions #9150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b65f8f to
69bb45a
Compare
This avoids incorrectly updating e.g. the ``backend`` or ``interactive`` rcParams.
|
Would be nice to get this in in relation with #11600, so I'll milestone as 3.0 (but not insisting on it). |
|
Probably should extend the tests that exist right now for blacklisting. Otherwise, looks good to me. |
|
Can't see any blacklisting tests in https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_style.py. Not saying they shouldn't be added, but that can perhaps be a separate PR? |
|
huh, I could have sworn there were some. I even checked test_rcsetup.py,
which has a bunch of tests for these functions as well.
…On Thu, Jul 12, 2018 at 12:04 PM, Antony Lee ***@***.***> wrote:
Can't see any blacklisting tests in https://github.com/matplotlib/
matplotlib/blob/master/lib/matplotlib/tests/test_style.py. Not saying
they shouldn't be added, but that can perhaps be a separate PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9150 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-Mf9h8NqIdgDVd93mtASWJTiRWWWks5uF3ObgaJpZM4PK1uf>
.
|
tacaswell
approved these changes
Jul 15, 2018
timhoffm
approved these changes
Jul 15, 2018
|
CircleCI fails because it cannot load font-humor-sans. This is onrelated to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #9135
PR Summary
Don't update style-blacklisted rcparams in rc_* functions.
This avoids e.g. incorrectly updating the "backend" or "interactive" rcParams.
PR Checklist