Let dpi be set when saving JPEG using Agg backend #9066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Aug 21, 2017
WeatherGod
reviewed
Aug 21, 2017
|
|
||
| if 'quality' not in options: | ||
| options['quality'] = rcParams['savefig.jpeg_quality'] | ||
| # Set the same dpi in both x and y directions | ||
| options['dpi'] = (options['dpi'], options['dpi']) |
There was a problem hiding this comment.
If the dpi wasn't set from the options, should it fetch it from the rcparams? (or does that already happen in building kwargs)?
There was a problem hiding this comment.
It is probably better to be defensive about it if 'dpi' in options
|
Does pillow provide access to a way to access the meta-data? Maybe use |
|
@dstansby This seems to need a rebase. |
|
Conflict is from #9071 |
Check that dpi is in options
WeatherGod
approved these changes
Aug 25, 2017
anntzer
reviewed
Sep 9, 2017
| plt.plot([0, 1, 2], [0, 1, 0]) | ||
| plt.savefig('test.jpg', dpi=200) | ||
| im = Image.open("test.jpg") | ||
| assert im.info['dpi'] == (200, 200) |
There was a problem hiding this comment.
This should delete test.jpg after it is done (or, more simply, just write the file to a bytesio).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes (for the Agg backend) #9035. Not sure if there's a test I can put in, but I have checked that preview on macOS reports the correct dpi when I manually change the dpi.