Cleanup to image.py. #9032
Merged
Cleanup to image.py. #9032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Aug 23, 2017
lib/matplotlib/image.py
Outdated
| One of the file extensions supported by the active backend. Most | ||
| backends support png, pdf, ps, eps and svg. | ||
| origin : [ 'upper' | 'lower' ] | ||
| Indicates where the ``(0, 0)`` index of the array is in the upper left |
| x = np.fromstring(x_str, dtype) | ||
| return x | ||
|
|
||
| if pilImage.mode in ('RGBA', 'RGBX'): |
There was a problem hiding this comment.
accidentally lost it; put it back
PIL.Image.Image.tobytes has existed since Pillow 2.0, which was released in March 2013, and is also the first version to support Python 3. One may want to add a check for the Pillow version, although it is superfluous on Py3. (While updating the docs on the required version of Pillow, also remove mencoder from the dependencies doc, as its support is deprecated anyways.)
dopplershift
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanups.
PIL.Image.Image.tobytes has existed since Pillow 2.0, which was released
in March 2013, and is also the first version to support Python 3.
One may want to add a check for the Pillow version, although it is
superfluous on Py3.
(While updating the docs on the required version of Pillow, also remove
mencoder from the dependencies doc, as its support is deprecated
anyways.)
PR Summary
PR Checklist