Revert "Merge pull request #5754 from blink1073/ipython-widget" #9027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get" This reverts commit 9c100c9, reversing changes made to 6bed1be. The reason for doing this is that ipywidgets is still moving much too fast for Matplotlib to keep up with. The original work done in matplotlib#5754 was done against ipywidgets v4, as of now the final touches are being put on v7. We are reverting back to our old inject-into-the-DOM method from `nbagg`, which is what is used by `%matplotlib notebook`. For embedding as a 'proper' widget use ipympl (github.com/matplotlib/jupyter-wigets) which will release on a schedule that matches the upstream jupyter ecosystem. closes matplotlib#7695
dopplershift
approved these changes
Aug 14, 2017
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 23, 2017
These files were moved as part of matplotlib#5754 which was reverted in matplotlib#9027, however matplotlib#6370 fixed the paths, but was not also reverted. Putting the js files in sub-directory makes sense, move the files rather than revert the changes in matplotlib#6370. fixes matplotlib#9380
This was referenced Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9c100c9, reversing
changes made to 6bed1be.
The reason for doing this is that ipywidgets is still moving much too
fast for Matplotlib to keep up with. The original work done in #5754
was done against ipywidgets v4, as of now the final touches are being
put on v7.
We are reverting back to our old inject-into-the-DOM method from
nbagg, which is what is used by%matplotlib notebook.For embedding as a 'proper' widget use
ipympl (github.com/matplotlib/jupyter-wigets) which will release on a
schedule that matches the upstream jupyter ecosystem.
closes #7695
PR Summary
PR Checklist