10BC0 Sty solarized by tacaswell · Pull Request #9026 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Sty solarized #9026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
choldgraf merged 4 commits into from
Aug 17, 2017
Merged

Sty solarized #9026

choldgraf merged 4 commits into from
Aug 17, 2017

Conversation

@tacaswell
Copy link
Member
@tacaswell tacaswell commented Aug 13, 2017

Rebase of #3851

PR Summary

PR Checklist

  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant

ilivni and others added 2 commits August 12, 2017 21:22
@ilivni @tacaswell
Solarize_Light2
b7ad0f2 
Adapted from ggplot2

Title padding
Title color
Minor grid width
Alpha for graphs with a "fill"

Solarized_License

Taken from the Solarized Github page:
https://github.com/altercation/solarized

Example Script

No changes to the mplstyle.

Changed Name of File

File Conventions

Conforming to matplolib conventions

Deleted Some Empty Lines

Failed last  Travis regression

Get Rid of white spaces 2

Solaraized Light Style File Fixed

style sheet remove white spaces

Tried setting the user save preference
"trim_trailing_white_space_on_save": true

3rd Try White Spaces

Used convert tabs -> spaces script

Used PSPAD to check whitespace

Set Sublime to UNIX Line style endings

Tried Unix style line endings with sublime
@tacaswell
MNT/DOC: whitespace + updated example heading
e5b5da0
@tacaswell tacaswell added this to the 2.1 (next point release) milestone Aug 13, 2017
@tacaswell tacaswell mentioned this pull request Aug 13, 2017
Closed
@dopplershift dopplershift changed the title Sty solaized Sty solarized Aug 14, 2017
@tacaswell
Copy link
Member Author
tacaswell commented Aug 14, 2017

https://561-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/style_sheets/plot_solarizedlight2.html

image

@dopplershift
Copy link
Contributor
dopplershift commented Aug 14, 2017

Here's the proper link for pygal:

http://pygal.org/en/stable/documentation/builtin_styles.html#light-solarized

@choldgraf choldgraf merged commit 5044788 into matplotlib:master Aug 17, 2017
@QuLogic
Copy link
Member
QuLogic commented Aug 17, 2017

I still don't understand why there's a 2 in the name.

@tacaswell tacaswell deleted the sty_solaized branch August 27, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@tacaswell @dopplershift @QuLogic @choldgraf @ilivni
0