8000 If Legend shadow=True set framealpha=1 if not passed explicitly instead of consulting rcParams by s0vereign · Pull Request #8988 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

If Legend shadow=True set framealpha=1 if not passed explicitly instead of consulting rcParams #8988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 11, 2017
Merged

If Legend shadow=True set framealpha=1 if not passed explicitly instead of consulting rcParams #8988

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
04ef849
Added the Fix for Issue 8943 and a simple testcase.
s0vereign Aug 4, 2017
0808634
removed unecessary lines
s0vereign Aug 4, 2017
538da87
Fixed pep8 violations in test case
s0vereign Aug 4, 2017
a030a8d
alpha of legend is now set with set_alpha method and thus changed
s0vereign Aug 4, 2017
569c4f5
Added blank line in test_legend.py at EOF for pep8 compliance
s0vereign Aug 9, 2017
755d9c8
Added lines to lib/matplotlib/axes/_axes.py to account
s0vereign Aug 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added lines to lib/matplotlib/axes/_axes.py to account 
for ignoring framealpha default value if shadow is
activated.
  • Loading branch information
@s0vereign
s0vereign committed Aug 9, 2017
commit 755d9c8ffd01bba14372b05373132cd810e5c800
2 changes: 2 additions & 0 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,8 @@ def legend(self, *args, **kwargs):
Control the alpha transparency of the legend's background.
Default is ``None`` which will take the value from the
``legend.framealpha`` :data:`rcParam<matplotlib.rcParams>`.
If shadow is activated and framealpha is ``None`` the
default value is being ignored.

facecolor : None or "inherit" or a color spec
Control the legend's background color.
Expand Down
0