8000 Workaround for islice int error in animation.py by braaannigan · Pull Request #8984 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Workaround for islice int error in animation.py #8984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 8, 2017
Merged

Workaround for islice int error in animation.py #8984

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a344081
workaround for islice int error
braaannigan Aug 3, 2017
044ed3b
changed position of int conversion
braaannigan Aug 3, 2017
1c60f48
added self
braaannigan Aug 4, 2017
27e248a
move into if statement
braaannigan Aug 7, 2017
7d9a685
added save_count assignment back in
braaannigan Aug 8, 2017
a975677
remove period
braaannigan Aug 8, 2017
a4f93e9
shorten line to < 80
braaannigan Aug 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added self
  • Loading branch information
@braaannigan
braaannigan committed Aug 4, 2017
commit 1c60f48ce82bea4f8df9572b3350d848e0b8bf28
2 changes: 1 addition & 1 deletion lib/matplotlib/animation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,7 +1568,7 @@ def __init__(self, fig, func, frames=None, init_func=None, fargs=None,
# of a native python int. This is a known issue:
# http://bugs.python.org/issue30537
# As a workaround, enforce conversion to native python int.
self.save_count = int(save_count)
self.save_count = int(self.save_count)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to do the whole block, like:

if save_count is None:
    self.save_count = 100
else:
    self.save_count = int(save_count)


self._init_func = init_func

Expand Down
0