8000 Update colorbar.py by keithbriggs · Pull Request #8970 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Update colorbar.py #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2017
Merged

Update colorbar.py #8970

merged 2 commits into from
Aug 1, 2017

Conversation

keithbriggs
Copy link
Contributor
@keithbriggs keithbriggs commented Jul 31, 2017 •
edited
Loading

Clarified documentation of "shirink".

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@keithbriggs
Update colorbar.py
f5f20bf 
Clarified documentation of "shirink".
@keithbriggs keithbriggs reopened this Jul 31, 2017
tacaswell
tacaswell reviewed Jul 31, 2017
View reviewed changes
lib/matplotlib/colorbar.py Outdated
@@ -52,7 +52,7 @@
*fraction* 0.15; fraction of original axes to use for colorbar
*pad* 0.05 if vertical, 0.15 if horizontal; fraction
of original axes between colorbar and new image axes
*shrink* 1.0; fraction by which to shrink the colorbar
*shrink* 1.0; fraction by which to multiply the size of the colorbar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is now 2 spaces between 'of' and 'the'?

@tacaswell
Copy link
Member

Thanks @keithbriggs ! I think this added a small typo, once that is fixed 👍

dstansby
dstansby approved these changes Aug 1, 2017
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dstansby dstansby merged commit e477912 into matplotlib:master Aug 1, 2017
@dstansby dstansby added this to the 2.1 (next point release) milestone Aug 1, 2017
@tacaswell
Copy link
Member

@keithbriggs Congratulations on your first Matplotlib contribution 🎉

Hopefully we will hear from you again!

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell left review comments

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@keithbriggs @tacaswell @dstansby
0