8000 Remove semicolon after PyObject_HEAD. by anntzer · Pull Request #8925 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove semicolon after PyObject_HEAD. #8925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2017
Merged

Remove semicolon after PyObject_HEAD. #8925

merged 1 commit into from
Jul 22, 2017

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jul 22, 2017

Just a cleanup.

See https://docs.python.org/3/extending/newtypes.html#the-basics:

Note that there is no semicolon after the PyObject_HEAD macro; one is
included in the macro definition. Be wary of adding one by accident;
it’s easy to do from habit, and your compiler might not complain, but
someone else’s probably will!

Also move a FT2Font *x; declaration to its own line (that was the
original motivation).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove semicolon after PyObject_HEAD.
aff7290 
See https://docs.python.org/3/extending/newtypes.html#the-basics:

> Note that there is no semicolon after the PyObject_HEAD macro; one is
included in the macro definition. Be wary of adding one by accident;
it’s easy to do from habit, and your compiler might not complain, but
someone else’s probably will!

Also move a FT2Font *x; declaration to its own line (that was the
original motivation).
@tacaswell tacaswell merged commit 062beb6 into matplotlib:master Jul 22, 2017
@tacaswell
Copy link
Member

drat, did not mean to squash-merge that...

@anntzer anntzer deleted the pyobject_head branch July 22, 2017 19:44
@QuLogic QuLogic modified the milestone: 2.1 (next point release) Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @dopplershift @QuLogic
0