8000 Fix exception in plt.tight_layout() by mollyrossow · Pull Request #8891 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix exception in plt.tight_layout() #8891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2017
Merged

Fix exception in plt.tight_layout() #8891

merged 3 commits into from
Jul 18, 2017

Conversation

mollyrossow
Copy link
Contributor

PR Summary

This PR addresses issue #8578 (Exception in plt.tight_layout()) and stops tight_layout from raising an exception when there are no axes in a figure.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/whats_new.rst if major new feature
  • [n/a] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 16, 2017
@tacaswell
Copy link
Member

Thanks @mollyrossow !

@QuLogic QuLogic merged commit c2f3788 into matplotlib:master Jul 18, 2017
ngoldbaum
ngoldbaum reviewed Jul 18, 2017
View reviewed changes
Copy link
Contributor
@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning an empty dict seems sensible. LGTM

@tacaswell
Copy link
Member

@mollyrossow Thanks and congratulations on your first Matplotlib contribution 🎉

Hope we hear from you again!

@tacaswell tacaswell mentioned this pull request Jul 18, 2017
Closed
@tacaswell tacaswell mentioned this pull request May 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoldbaum ngoldbaum ngoldbaum left review comments

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mollyrossow @tacaswell @ngoldbaum @QuLogic
0