8000 Update pylab example to OO format by dmgt · Pull Request #8886 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Update pylab example to OO format #8886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2017
Merged

Update pylab example to OO format #8886

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c15f5a6
changed example to OO format
dmgt Jul 15, 2017
b1177e4
Fixed typo
dmgt Jul 15, 2017
cf40b7c
Removed blank line at end of file
dmgt Jul 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
changed example to OO format
  • Loading branch information
@dmgt
dmgt committed Jul 15, 2017
commit c15f5a64888b9c49c4bb1cdca9ba0388e2849e74
9 changes: 6 additions & 3 deletions examples/pylab_examples/log_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""
i"""
========
Log Axis
========
Expand All @@ -10,10 +10,13 @@
import matplotlib.pyplot as plt
import numpy as np

fig, ax = plt.subplots()

dt = 0.01
t = np.arange(dt, 20.0, dt)

plt.semilogx(t, np.exp(-t/5.0))
plt.grid(True)
ax.semilogx(t, np.exp(-t / 5.0))
ax.grid()

plt.show()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the travis log, but I wouldn't be surprised this blank line is a PEP8 violation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that it was the oppose - that blank lines at the end of a file are required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there needs to be a newline at the end?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at travis I think you're right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I fixed it

0