8000 Fix eventplot colors kwarg by tacaswell · Pull Request #8861 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix eventplot colors kwarg #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2017
Merged

Fix eventplot colors kwarg #8861

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78e2134
Naive fix for issue 8193
afvincent Mar 4, 2017
79c00e9
Add a non-picture test dedicated to the 'colors' parameter
afvincent Mar 5, 2017
5214a62
eventplot and EventCollection docstrings overhaul (+ make the latter …
afvincent Mar 5, 2017
4d4fe07
Fix the phrasing of some sentences.
afvincent Mar 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Naive fix for issue 8193
  • Loading branch information
@afvincent @tacaswell
afvincent authored and tacaswell committed Jul 11, 2017
commit 78e2134d1d17f245f85b580354cd6da169a3a20b
9 changes: 9 additions & 0 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,6 +1181,15 @@ def eventplot(self, positions, orientation='horizontal', lineoffsets=1,
lineoffsets = [None]
if len(colors) == 0:
colors = [None]
try:
# Early conversion of the colors into RGBA values to take care
# of cases like colors='0.5' or colors='C1'. (Issue #8193)
colors = mcolors.to_rgba_array(colors)
except ValueError:
# Will fail if any element of *colors* is None. But as long
# as len(colors) == 1 or len(positions), the rest of the
# code should process *colors* properly.
pass

if len(lineoffsets) == 1 and len(positions) != 1:
lineoffsets = np.tile(lineoffsets, len(positions))
Expand Down
0